feat: add flagtype package with common flag.Value implementations#13
Merged
feat: add flagtype package with common flag.Value implementations#13
Conversation
09acd79 to
1ec9e49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
flagtypepackage that provides ready-madeflag.Valueimplementations for common types that the stdlibflagpackage doesn't cover.The supported types are:
StringSlice(repeatable flags)Enum(restricted value set)StringMap(repeatable key=value pairs)URL(parsed and validated)Regexp(compiled pattern).All types implement
flag.Getterso they integrate withcli.GetFlag[T]. Storage is internal to each value -- no destination pointers needed.Also includes a design doc at
docs/design/001-flagtype-api.mdcovering the API decision and alternatives considered.